scheduler: Log process info when its affinity cannot be changed and re-check blacklisted cgroups #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include its current affinity, cmdline, and cgroup. This may help identify issues with tuning, e.g., in cases when the process disappears soon after affining it fails. Resolves: RHEL-69933
zacikpa
changed the title
zacikpa
force-pushed
the
affinity-error-logs
branch
from
a6ff726 to
30d9a34
Compare
zacikpa
force-pushed
the
affinity-error-logs
branch
from
30d9a34 to
d74e8d4
Compare
|
One more update per discussion with @MarSik: do the cgroup blacklist check as close to the affinity setting as possible to minimize the race window. I removed the initial blacklist filtering, but feel free to comment on that; we can keep it for efficiency. |
It may happen that a process gets moved into a blacklisted cgroup when TuneD is already applying a profile. Postpone the filtering of processes according to the blacklist to the last possible moment to minimize the race window. When setting process affinity fails, re-check whether the process belongs to a blacklisted cgroup once again and do not report an error if that's the case. Resolves: RHEL-72981
zacikpa
force-pushed
the
affinity-error-logs
branch
from
d74e8d4 to
7113c91
Compare
|
/lgtm |
MarSik
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the current affinity of the process, its cmdline, and its cgroups in the logs. This may help identify issues with tuning, e.g., in cases when the process disappears soon after affining it fails.
Resolves: RHEL-69933
Update: It may happen that a process gets moved into a blacklisted cgroup
after the initial filtering of processes according to the blacklist.
When setting its affinity fails, re-check whether that is the case,
and if yes, ignore the error.
Resolves: RHEL-72981